brobert
/
taskbot
1
0
Fork 0
Code Issues Pull Requests 1 Packages Projects Releases Wiki Activity

refactor: reemplaza verificación de membresía por enforceMembership

Browse Source 
Co-authored-by: aider (openrouter/openai/gpt-5) <aider@aider.chat>
main
brobert 4 days ago
parent 6daa27f4ad
commit 1356a2d1d7
1 changed files with 6 additions and 11 deletions
Show Stats Download Patch File Download Diff File

17
src/services/command.ts
Unescape Escape View File

@ -13,7 +13,7 @@ import { Metrics } from './metrics';
import { ResponseQueue } from './response-queue'; import { ResponseQueue } from './response-queue';
import { randomTokenBase64Url, sha256Hex } from '../utils/crypto'; import { randomTokenBase64Url, sha256Hex } from '../utils/crypto';
import { route as routeCommand } from './commands'; import { route as routeCommand } from './commands';
import { ACTION_ALIASES, SCOPE_ALIASES, todayYMD as todayYMD_TZ, resolveTaskIdFromInput, parseMultipleIds } from './commands/shared'; import { ACTION_ALIASES, SCOPE_ALIASES, todayYMD as todayYMD_TZ, resolveTaskIdFromInput, parseMultipleIds, enforceMembership } from './commands/shared';
import { parseNueva } from './commands/parsers/nueva'; import { parseNueva } from './commands/parsers/nueva';
type CommandContext = { type CommandContext = {
@ -357,8 +357,7 @@ export class CommandService {
message: `⚠️ Tarea ${codeId(resolvedId)} no encontrada.` message: `⚠️ Tarea ${codeId(resolvedId)} no encontrada.`
}]; }];
} }
const enforce = String(process.env.GROUP_MEMBERS_ENFORCE || '').toLowerCase() === 'true'; if (!enforceMembership(context.sender, task)) {
if (task && task.group_id && GroupSyncService.isSnapshotFresh(task.group_id) && enforce && !GroupSyncService.isUserActiveInGroup(context.sender, task.group_id)) {
return [{ return [{
recipient: context.sender, recipient: context.sender,
message: 'No puedes completar esta tarea porque no eres de este grupo.' message: 'No puedes completar esta tarea porque no eres de este grupo.'
@ -389,7 +388,6 @@ export class CommandService {
} }
// Modo múltiple // Modo múltiple
const enforce = String(process.env.GROUP_MEMBERS_ENFORCE || '').toLowerCase() === 'true';
let cntUpdated = 0, cntAlready = 0, cntNotFound = 0, cntBlocked = 0; let cntUpdated = 0, cntAlready = 0, cntNotFound = 0, cntBlocked = 0;
const lines: string[] = []; const lines: string[] = [];
@ -406,7 +404,7 @@ export class CommandService {
} }
const task = TaskService.getTaskById(resolvedId); const task = TaskService.getTaskById(resolvedId);
if (task && task.group_id && GroupSyncService.isSnapshotFresh(task.group_id) && enforce && !GroupSyncService.isUserActiveInGroup(context.sender, task.group_id)) { if (!enforceMembership(context.sender, task)) {
lines.push(`🚫 ${codeId(resolvedId)} — no permitido (no eres miembro activo).`); lines.push(`🚫 ${codeId(resolvedId)} — no permitido (no eres miembro activo).`);
cntBlocked++; cntBlocked++;
continue; continue;
@ -475,8 +473,7 @@ export class CommandService {
message: `⚠️ Tarea ${codeId(resolvedId)} no encontrada.` message: `⚠️ Tarea ${codeId(resolvedId)} no encontrada.`
}]; }];
} }
const enforce = String(process.env.GROUP_MEMBERS_ENFORCE || '').toLowerCase() === 'true'; if (!enforceMembership(context.sender, task)) {
if (task.group_id && GroupSyncService.isSnapshotFresh(task.group_id) && enforce && !GroupSyncService.isUserActiveInGroup(context.sender, task.group_id)) {
return [{ return [{
recipient: context.sender, recipient: context.sender,
message: 'No puedes tomar esta tarea porque no eres de este grupo.' message: 'No puedes tomar esta tarea porque no eres de este grupo.'
@ -517,7 +514,6 @@ export class CommandService {
} }
// Modo múltiple // Modo múltiple
const enforce = String(process.env.GROUP_MEMBERS_ENFORCE || '').toLowerCase() === 'true';
let cntClaimed = 0, cntAlready = 0, cntCompleted = 0, cntNotFound = 0, cntBlocked = 0; let cntClaimed = 0, cntAlready = 0, cntCompleted = 0, cntNotFound = 0, cntBlocked = 0;
const lines: string[] = []; const lines: string[] = [];
@ -534,7 +530,7 @@ export class CommandService {
} }
const task = TaskService.getTaskById(resolvedId); const task = TaskService.getTaskById(resolvedId);
if (task && GroupSyncService.isSnapshotFresh(task.group_id) && enforce && !GroupSyncService.isUserActiveInGroup(context.sender, task.group_id)) { if (!enforceMembership(context.sender, task)) {
lines.push(`🚫 ${codeId(resolvedId)} — no permitido (no eres miembro activo).`); lines.push(`🚫 ${codeId(resolvedId)} — no permitido (no eres miembro activo).`);
cntBlocked++; cntBlocked++;
continue; continue;
@ -601,8 +597,7 @@ export class CommandService {
message: `⚠️ Tarea ${codeId(resolvedId)} no encontrada.` message: `⚠️ Tarea ${codeId(resolvedId)} no encontrada.`
}]; }];
} }
const enforce = String(process.env.GROUP_MEMBERS_ENFORCE || '').toLowerCase() === 'true'; if (!enforceMembership(context.sender, task)) {
if (task.group_id && GroupSyncService.isSnapshotFresh(task.group_id) && enforce && !GroupSyncService.isUserActiveInGroup(context.sender, task.group_id)) {
return [{ return [{
recipient: context.sender, recipient: context.sender,
message: '⚠️ No puedes soltar esta tarea porque no eres de este grupo.' message: '⚠️ No puedes soltar esta tarea porque no eres de este grupo.'

Write Preview
Loading…
Cancel
Save